javascript - Refactoring WeatherSlider code -


i working weatherslider widget http://kreaturamedia.com/weatherslider-premium-jquery-weather-widget/ client’s intranet , refactor wrote facilitate readability.

so far have:

$(document).ready(function() {      $('.ws-widget').weatherslider({         imgpath : 'includes/weatherslider/img/',          cssanimations : true,         jsanimations : true,         snow : true,         rain : true,         wind : true,         lightnings : true,          //further options removed brevity          wwoapikey : '3jwfoo7mk9ktvgrnsbythbar'     }); });  $('ul li a').click(function() {      var cityloc = $(this).attr("data-city");      if (cityloc == 'toronto') {          var data = '<span class="ws-location">toronto, ontario, canada</span>';         $(".ws-widget").hide().html(data).fadein('fast');          $('.ws-widget').weatherslider({             imgpath : 'includes/weatherslider/img/',              cssanimations : true,             jsanimations : true,             snow : true,             rain : true,             wind : true,             lightnings : true,              //further options removed brevity              wwoapikey : '3jwfoo7mk9ktvgrnsbythbar'         });      } else if (cityloc == 'montreal') {          var data = '<span class="ws-location">montreal, quebec, canada</span>';         $(".ws-widget").hide().html(data).fadein('fast');          $('.ws-widget').weatherslider({             imgpath : 'includes/weatherslider/img/',              cssanimations : true,             jsanimations : true,             snow : true,             rain : true,             wind : true,             lightnings : true,              //further options removed brevity              wwoapikey : '3jwfoo7mk9ktvgrnsbythbar'         });      } else if (cityloc == 'calgary') {          var data = '<span class="ws-location">calgary, alberta, canada</span>';         $(".ws-widget").hide().html(data).fadein('fast');          $('.ws-widget').weatherslider({             imgpath : 'includes/weatherslider/img/',              cssanimations : true,             jsanimations : true,             snow : true,             rain : true,             wind : true,             lightnings : true,              //further options removed brevity              wwoapikey : '3jwfoo7mk9ktvgrnsbythbar'         });      } else if (cityloc == 'vancouver') {          var data = '<span class="ws-location">vancouver, british columbia, canada</span>';         $(".ws-widget").hide().html(data).fadein('fast');          $('.ws-widget').weatherslider({             imgpath : 'includes/weatherslider/img/',              cssanimations : true,             jsanimations : true,             snow : true,             rain : true,             wind : true,             lightnings : true,              //further options removed brevity              wwoapikey : '3jwfoo7mk9ktvgrnsbythbar'         });      } else if (cityloc == 'london') {          var data = '<span class="ws-location">london, uk</span>';         $(".ws-widget").hide().html(data).fadein('fast');          $('.ws-widget').weatherslider({             imgpath : 'includes/weatherslider/img/',              cssanimations : true,             jsanimations : true,             snow : true,             rain : true,             wind : true,             lightnings : true,              //further options removed brevity              wwoapikey : '3jwfoo7mk9ktvgrnsbythbar'         });     }      return false; });

what .weatherslider() call used in $(document).ready(function()) used in of conditional sections of $('ul li a').click(function())

i thought there might little more involved in refactoring bit of code, however, solution found in simple wrapping code wanted reused in function.

i guess first rule in kiss.

function weathersettings() {     $('.ws-widget').weatherslider({         imgpath : 'includes/weatherslider/img/',          cssanimations : true,         jsanimations : true,         snow : true,         rain : true,         wind : true,         lightnings : true,          //further options removed brevity          wwoapikey : '3jwfoo7mk9ktvgrnsbythbar'     }); }   $(document).ready(function() {     weathersettings(); });  $('ul li a').click(function() {      var cityloc = $(this).attr("data-city");      if (cityloc == 'toronto') {          var data = '<span class="ws-location">toronto, ontario, canada</span>';         $(".ws-widget").hide().html(data).fadein('fast');          weathersettings();      } else if (cityloc == 'montreal') {          var data = '<span class="ws-location">montreal, quebec, canada</span>';         $(".ws-widget").hide().html(data).fadein('fast');          weathersettings();      } else if (cityloc == 'calgary') {          var data = '<span class="ws-location">calgary, alberta, canada</span>';         $(".ws-widget").hide().html(data).fadein('fast');          weathersettings();      } else if (cityloc == 'vancouver') {          var data = '<span class="ws-location">vancouver, british columbia, canada</span>';         $(".ws-widget").hide().html(data).fadein('fast');          weathersettings();      } else if (cityloc == 'london') {          var data = '<span class="ws-location">london, uk</span>';         $(".ws-widget").hide().html(data).fadein('fast');          weathersettings();     }      return false; });

Comments

Post a Comment

Popular posts from this blog

html - How to style widget with post count different than without post count -

i have border below li elements in wordpress widget types appropriate. element inside set block gives them nice easy click full width. the problem, when choose option "show post count" when adding widget such categories or archives displays post count plain text after tag , because tag block pushes post number text line below. whether choose show post count or not show post count still gives exact same element identifyer example "widget_categories". how style post count not on next line still keep links non post count list items full width? here's example on sidebar www.bbmthemes.com/themes/modular/blog-standard/ in order solve problem need remove display:block; for ul.widgets ul a , add in it's place line-height: 33px; what going achieve have same visual effect. what going lose doing links going work on text , not on "box". the other way out of find post count coming , make changes this. example change text count i
Read more

How to remove text and logo OR add Overflow on Android ActionBar using AppCompat on API 8? -

have researched death , cannot find answer. i have actionbar using appcompat. supporting api v7 (api v8 do). actionbar works api v11. api < v11 has problem of removing icon (and feature) actionbar without supplying overflow. big picture have app logo, app title, , 3 icons squidging same actionbar on low end phone. trying make room! i happy 1 of 2 solutions. either: a method of getting overflow functionality can retrieved pull down. (preferred) method of removing icon , text actionbar below current xml api 11+: <resources> <!-- base application theme api 11+. theme replaces appbasetheme res/values/styles.xml on api 11+ devices. --> <style name="appbasetheme" parent="theme.appcompat.light.darkactionbar"> <item name="android:actionbarstyle">@style/liteactionbarstyle</item> <item name="actionbarstyle">@style/liteactionbarstyle</item> </st
Read more

javascript - storing input from prompt in array and displaying the array -

i want take the inputs user prompt, store input in array, , display it. want take 10 inputs user using for loop. have tried do-while shown below. var givennames = new array(); var pattern = /[\w\d]{1,}/ig; do{ var name = prompt("enter names. letters , digits accepted!\nentering empty field stops asking",""); if(name && name.match(pattern)){givennames.push(name);} } while(name != ""); function displaynames(){ if(givennames.length > 0){ document.getelementbyid("list").innerhtml = "<span style='color:navy;font- weight:bold;'>given names are:<\/span><br><br>" + givennames.join("<br><br>"); } else { document.getelementbyid("list").innerhtml = "<span style='color:navy;font-weight:bold;'>nothing has been given!<\/span>"; } } how replace for loop? var givennames = new array();
Read more