php - Too much dependency injection? -


i'm re-factoring large application quite bit of spaghetti legacy code more structured , easy maintain, , importantly, testable. can see injecting classes dependencies them opposed mixing object creation business logic makes writing unit tests easier.

i've read comments effect of "using dependency injection improperly causes more problems solves." mean? such sophisticated verbiage, dependency injection seems pretty simple concept. how abuse idea of sending dependencies in through constructor rather instantiating them within dependent class? why latter ever preferable?

all can see right makes isolating functionality write tests , mocking objects extremely easy. seems making ridiculously obvious when class has many responsibilities , points directly @ classes need refactored. getting carried away if i'm avoiding use of new keyword anywhere other di container (with exception of core php classes)?

i wouldn't worry going overboard dependency injection. have stated of benefits have seen adopting (test-ability, encouraging design re separation of concerns).

a criticism have heard made of dependency injection (and ioc) can introduce complexity. while possible over-complicate things due bad implementation, can not agree complaint intrinsic problem dependency injection.

the thing keep eye on choose the right level of abstraction , indirection dependencies give the flexibility need. many levels of indirection can add complexity no value, argue orthogonal issue dependency injection.

see this related question more possible downsides dependency injection :)

regarding issue of many dependencies included in original question prior editing:

having many dependencies can code smell, , things focus on address should be:

it sounds have tackled part of problem following these principles. should @ whether classes implement appropriate levels of abstraction. example, class needs access multiple data models may benefit accessing them through facade or repository.


Comments

Post a Comment

Popular posts from this blog

html - How to style widget with post count different than without post count -

i have border below li elements in wordpress widget types appropriate. element inside set block gives them nice easy click full width. the problem, when choose option "show post count" when adding widget such categories or archives displays post count plain text after tag , because tag block pushes post number text line below. whether choose show post count or not show post count still gives exact same element identifyer example "widget_categories". how style post count not on next line still keep links non post count list items full width? here's example on sidebar www.bbmthemes.com/themes/modular/blog-standard/ in order solve problem need remove display:block; for ul.widgets ul a , add in it's place line-height: 33px; what going achieve have same visual effect. what going lose doing links going work on text , not on "box". the other way out of find post count coming , make changes this. example change text count i
Read more

How to remove text and logo OR add Overflow on Android ActionBar using AppCompat on API 8? -

have researched death , cannot find answer. i have actionbar using appcompat. supporting api v7 (api v8 do). actionbar works api v11. api < v11 has problem of removing icon (and feature) actionbar without supplying overflow. big picture have app logo, app title, , 3 icons squidging same actionbar on low end phone. trying make room! i happy 1 of 2 solutions. either: a method of getting overflow functionality can retrieved pull down. (preferred) method of removing icon , text actionbar below current xml api 11+: <resources> <!-- base application theme api 11+. theme replaces appbasetheme res/values/styles.xml on api 11+ devices. --> <style name="appbasetheme" parent="theme.appcompat.light.darkactionbar"> <item name="android:actionbarstyle">@style/liteactionbarstyle</item> <item name="actionbarstyle">@style/liteactionbarstyle</item> </st
Read more

javascript - storing input from prompt in array and displaying the array -

i want take the inputs user prompt, store input in array, , display it. want take 10 inputs user using for loop. have tried do-while shown below. var givennames = new array(); var pattern = /[\w\d]{1,}/ig; do{ var name = prompt("enter names. letters , digits accepted!\nentering empty field stops asking",""); if(name && name.match(pattern)){givennames.push(name);} } while(name != ""); function displaynames(){ if(givennames.length > 0){ document.getelementbyid("list").innerhtml = "<span style='color:navy;font- weight:bold;'>given names are:<\/span><br><br>" + givennames.join("<br><br>"); } else { document.getelementbyid("list").innerhtml = "<span style='color:navy;font-weight:bold;'>nothing has been given!<\/span>"; } } how replace for loop? var givennames = new array();
Read more