c++ - pointer problems with inherited class -


in below code secclass inheriting 'item' firstclass. when run 'classc' in main both first item , second item 210. if remove pointer inherited class(firstclass), runs should. i'm still rather shaky both pointers , inheritance there's i'm missing here...

// declaration of firstclass // firstclass.h  #include <iostream>  #ifndef firstclass_h #define firstclass_h  using namespace std;  class firstclass {  private:    int *item;   public:    firstclass();    firstclass(int thatitem);    ~firstclass();     int getitem();    void setitem(int thatitem);  };  #endif   // implementation of firstclass.h // firstclass.cpp  #include "firstclass.h"  using namespace std;  firstclass::firstclass() {  int *setinitial = new int; *setinitial = 5; item = setinitial; }  firstclass::firstclass(int thatitem) { item = &thatitem; }  firstclass::~firstclass(){}  int firstclass::getitem() {     return *item; }  void firstclass::setitem(int thatitem)  {     item = &thatitem; }   // declaration of secclass // secclass.h  #ifndef secclass_h #define secclass_h  #include "firstclass.h"  using namespace std;  class secclass : public firstclass {  private:    int *secitem;   public:    secclass();    secclass(int newitem, int thatitem);    ~secclass();     int getsecitem();    void setsecitem(int newitem);  };  #endif   // implementation of secclass.h // secclass.cpp  #include "secclass.h"  using namespace std;  secclass::secclass() {  int *setsecinitial = new int; *setsecinitial = 16; secitem = setsecinitial; }  secclass::secclass(int newitem, int thatitem) : firstclass(thatitem) {     secitem = &newitem; }  secclass::~secclass(){}  int secclass::getsecitem() {     return *secitem; }  void secclass::setsecitem(int newitem)  {     secitem = &newitem; }   // main program #include <iostream> #include "firstclass.h" #include "secclass.h"  using namespace std;  int main() {  firstclass classa; cout << "classa item: " << classa.getitem() << endl << endl;  firstclass classz(86); cout << "classz item: " << classz.getitem() << endl << endl;  secclass classb; cout << "classb first item: " << classb.getitem() << endl; cout << "classb second item: " << classb.getsecitem() << endl << endl;  secclass classc(72, 210); cout << "classc first item: " << classc.getitem() << endl; cout << "classc second item: " << classc.getsecitem() << endl;   return 0; }

your constructor

void firstclass::setitem(int thatitem)  {     item = &thatitem; }

is doing bad thing, storing address of temporary object (the int passed constructor).

that int destroyed right after returning constructor , item pointer pointing memory area has been reused else.

anything can happen when kind of things (including daemons flying out of nostrils) don't that.


Comments

Post a Comment

Popular posts from this blog

html - How to style widget with post count different than without post count -

i have border below li elements in wordpress widget types appropriate. element inside set block gives them nice easy click full width. the problem, when choose option "show post count" when adding widget such categories or archives displays post count plain text after tag , because tag block pushes post number text line below. whether choose show post count or not show post count still gives exact same element identifyer example "widget_categories". how style post count not on next line still keep links non post count list items full width? here's example on sidebar www.bbmthemes.com/themes/modular/blog-standard/ in order solve problem need remove display:block; for ul.widgets ul a , add in it's place line-height: 33px; what going achieve have same visual effect. what going lose doing links going work on text , not on "box". the other way out of find post count coming , make changes this. example change text count i
Read more

How to remove text and logo OR add Overflow on Android ActionBar using AppCompat on API 8? -

have researched death , cannot find answer. i have actionbar using appcompat. supporting api v7 (api v8 do). actionbar works api v11. api < v11 has problem of removing icon (and feature) actionbar without supplying overflow. big picture have app logo, app title, , 3 icons squidging same actionbar on low end phone. trying make room! i happy 1 of 2 solutions. either: a method of getting overflow functionality can retrieved pull down. (preferred) method of removing icon , text actionbar below current xml api 11+: <resources> <!-- base application theme api 11+. theme replaces appbasetheme res/values/styles.xml on api 11+ devices. --> <style name="appbasetheme" parent="theme.appcompat.light.darkactionbar"> <item name="android:actionbarstyle">@style/liteactionbarstyle</item> <item name="actionbarstyle">@style/liteactionbarstyle</item> </st
Read more

javascript - storing input from prompt in array and displaying the array -

i want take the inputs user prompt, store input in array, , display it. want take 10 inputs user using for loop. have tried do-while shown below. var givennames = new array(); var pattern = /[\w\d]{1,}/ig; do{ var name = prompt("enter names. letters , digits accepted!\nentering empty field stops asking",""); if(name && name.match(pattern)){givennames.push(name);} } while(name != ""); function displaynames(){ if(givennames.length > 0){ document.getelementbyid("list").innerhtml = "<span style='color:navy;font- weight:bold;'>given names are:<\/span><br><br>" + givennames.join("<br><br>"); } else { document.getelementbyid("list").innerhtml = "<span style='color:navy;font-weight:bold;'>nothing has been given!<\/span>"; } } how replace for loop? var givennames = new array();
Read more